Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to ingest sys.configurations for SQL Server instances #15496

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Add support to ingest sys.configurations for SQL Server instances #15496

merged 7 commits into from
Aug 8, 2023

Conversation

jmeunier28
Copy link
Contributor

@jmeunier28 jmeunier28 commented Aug 7, 2023 •
edited
Loading

What does this PR do?

This PR follows on #14577, and allows us to ingest sqlserver instance configuration from the configurations view.

Motivation

Additional Notes

A good write up of what these configurations are can be found here

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@jmeunier28 jmeunier28 requested review from a team as code owners August 7, 2023 20:07
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ghost ghost added the documentation label Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #15496 (a3f18d6) into master (8bb548d) will increase coverage by 0.01%.
Report is 14 commits behind head on master.
The diff coverage is 97.67%.

Flag Coverage Δ
postgres 91.69% <100.00%> (-0.12%) ⬇️
sqlserver 87.11% <97.65%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

Test Results

     25 files       25 suites   1h 37m 21s ⏱️
   442 tests    429 ✔️   13 💤 0 ❌
3 335 runs  3 097 ✔️ 238 💤 0 ❌

Results for commit a3f18d6.

♻️ This comment has been updated with latest results.

@jmeunier28 jmeunier28 mentioned this pull request Aug 7, 2023
Merged
5 tasks
@jmeunier28 jmeunier28 merged commit 018d9a9 into master Aug 8, 2023
30 checks passed
@jmeunier28 jmeunier28 deleted the jmeunier/DBM-2448 branch August 8, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-normand alexandre-normand alexandre-normand approved these changes

Assignees
No one assigned
Labels
documentation integration/postgres integration/sqlserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmeunier28 @alexandre-normand